Use the clevis pin with the AK registration#202
Merged
alicefr merged 11 commits intotrusted-execution-clusters:mainfrom Feb 19, 2026
Merged
Use the clevis pin with the AK registration#202alicefr merged 11 commits intotrusted-execution-clusters:mainfrom
alicefr merged 11 commits intotrusted-execution-clusters:mainfrom
Conversation
Contributor
Author
|
Set to draft until I fully run the tests locally and fix the linting |
Contributor
Author
|
The tests passed locally |
attestation-key-register/src/main.rs
Outdated
Comment on lines
180
to
173
| let addr = SocketAddr::from(([0, 0, 0, 0], args.port)); | ||
| info!("Listening on {addr}"); | ||
| let addr: SocketAddr = ([0, 0, 0, 0], args.port).into(); | ||
| info!("Listening on {}", addr); |
Contributor
There was a problem hiding this comment.
nit: not sure why this block is necessary
register-server/src/main.rs
Outdated
| long, | ||
| default_value = "http://attestation-key-register:8001/register-ak" | ||
| )] | ||
| attestation_key_registration_url: String, |
Contributor
There was a problem hiding this comment.
Should this be mandatory? What about non-AK deployments?
alicefr
force-pushed
the
register-ak-uuid
branch
3 times, most recently
from
b5a0b55 to
14393ed
Compare
| // let initdata = Initdata { | ||
| // uuid: id.to_string(), | ||
| // }; | ||
| // ... initdata: serde_json::to_string(&initdata)?, |
Contributor
Author
There was a problem hiding this comment.
No, I also need to put the num_entries. I had some compilation issue
The AK registration endpoint is now part of the clevis pin configuration and it needs to be make configurable via the TEC CR. Signed-off-by: Alice Frosi <afrosi@redhat.com>
We match the attestation keys with the machine using the uuid and not the IP anymore. Therefore, there is a new field uuid in the AK spec and we removed the registration ip from the machine spec. Signed-off-by: Alice Frosi <afrosi@redhat.com>
Signed-off-by: Alice Frosi <afrosi@redhat.com>
The attesation key is now approved if there is an existing machine with the same uuid. Signed-off-by: Alice Frosi <afrosi@redhat.com>
The AK is now registered with the uuid and the public key content. Signed-off-by: Alice Frosi <afrosi@redhat.com>
Now, the clevis pin configuration includea the registration of the attestation key. Signed-off-by: Alice Frosi <afrosi@redhat.com>
Signed-off-by: Alice Frosi <afrosi@redhat.com>
We added a new field in the TEC CRD. Signed-off-by: Alice Frosi <afrosi@redhat.com>
…8e1bf40a0c3e The AK is approved if there is a matching machine with the same uuid. Update the behavior of the tests using the uuid instead of the ip. Signed-off-by: Alice Frosi <afrosi@redhat.com>
We cannot rely anymore on the IP since the machine is now only identified with the uuid. Instead, we now ssh into the VM, fetch the uuid from the clevis header and match the machine with the uuid. Signed-off-by: Alice Frosi <afrosi@redhat.com> Assisted-by: Claude
The new kubevirt image includes the clevis pin with the attestation key registration. Signed-off-by: Alice Frosi <afrosi@redhat.com>
alicefr
force-pushed
the
register-ak-uuid
branch
from
14393ed to
16532b2
Compare
Jakob-Naucke
approved these changes
Feb 19, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
@Jakob-Naucke let me give a last pass with the tests locally, if they pass I will merge it |
Contributor
Author
|
The test passed, merging |
alicefr
merged commit 5026319
into
trusted-execution-clusters:main
8 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on ignition for the AK registration, now we can use the clevis pin. The major difference is that now the we communicated the uuid for the AK registration, in this way the AK can be matched with the corresponding the machine based on the uuid instead of the ip.